My OSX build fails, probably because the geometry cache building takes too long

thomas · November 10, 2021, 4:00pm

Hi,
I am trying to write a new algorithm to load data for the position sensitive detector at DNS.

github.com/mantidproject/mantid

algorithm to read psd event data for the DNS instrument at MLZ

mantidproject:main ← thomueller:22871_read_DNS_psd_event_data

opened 02:20PM - 05 Oct 21 UTC

thomueller

+1192 -3

Fixes #22871. The PR adds the algorithm LoadDNSEvent, which is a loader for t…he Event data of the position sensitive detector of the DNS instrument at MLZ. It loads the events into an EventWorkspace. Requested by MLZ DNS instrumenent scientist = me. **To test:** This is also the example in the docs: filename = "DNS_psd_pulser_ON473_31.mdat" eventWS = LoadDNSEvent(InputFile=filename, ChopperChannel='2') print("Number of events: {}".format(eventWS.getNumberEvents())) print("Maximum time of flight: {}".format(eventWS.getTofMax())) print("Number of detector pixels: {}".format(eventWS.getNumberHistograms())) print("Number of bins: {}".format(eventWS.blocksize())) Should output: Number of events: 9998 Maximum time of flight: 99471.3 Number of detector pixels: 131072 Number of bins: 1 For release notes see [here](https://github.com/thomueller/mantid/commit/873d8f09e617a205fac722458254c980741c95e9). --- #### Reviewer #### Please comment on the following ([full description](http://developer.mantidproject.org/ReviewingAPullRequest.html)): ##### Code Review ##### - Is the code of an acceptable quality? - Does the code conform to the [coding standards](http://developer.mantidproject.org/Standards/)? - Are the unit tests small and test the class in isolation? - If there is GUI work does it follow the [GUI standards](http://developer.mantidproject.org/Standards/GUIStandards.html)? - If there are changes in the release notes then do they describe the changes appropriately? ##### Functional Tests ##### - Do changes function as described? Add comments below that describe the tests performed? - Do the changes handle unexpected situations, e.g. bad input? - Has the relevant (user and developer) documentation been added/updated? Does everything look good? Mark the review as **Approve**. A member of `@mantidproject/gatekeepers` will take care of it.

The OSX build fails:
https://builds.mantidproject.org/job/pull_requests-osx/46919/

10:50:28  772/2511 Test  #982: DataHandlingTest_LoadDNSEventTest ............................................................................................................***Timeout 300.06 sec
10:50:28 Running 9 tests...LoadDNSEvent-[Notice] LoadDNSEvent started
10:50:28 InstrumentDefinitionParser-[Notice] Geometry cache is not available
10:50:28 InstrumentDefinitionParser-[Notice] Creating cache in /Users/builder/.mantid/instrument/geometryCache/DNS-PSD03880f4077f70955e27452d25f5225b2327af287.vtp
10:50:28

I am not sure how to fix this, the instrument is large it has 131072 detectors.
I think the test might be failing just because it takes too long to create the geometry cache?
Or maybe something is wrong with the instrument definition file, but instrument view is working fine locally.

github.com

thomueller/mantid/blob/22871_read_DNS_psd_event_data/instrument/DNS-PSD_Definition.xml

<?xml version="1.0" encoding="utf-8"?>
<!-- For help on the notation used to specify an Instrument Definition File see http://www.mantidproject.org/IDF -->
<instrument xmlns="http://www.mantidproject.org/IDF/1.0"
            xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
            xsi:schemaLocation="http://www.mantidproject.org/IDF/1.0 http://schema.mantidproject.org/IDF/1.0/IDFSchema.xsd"
	    name="DNS-PSD" valid-from="2018-05-01 23:59:59" valid-to="2100-01-31 23:59:59" last-modified="2018-07-11 10:17:17">
  <!-- Author: t.mueller@fz-juelich.de -->
  <defaults>
    <length unit="meter" />
    <angle unit="degree" />
    <reference-frame>
      <!-- The z-axis is set parallel to and in the direction of the beam. the 
             y-axis points up and the coordinate system is right handed. -->
      <along-beam axis="z" />
      <pointing-up axis="y" />
      <handedness val="right" />
    </reference-frame>
  </defaults>
  <!-- chopper -->
  <component type="chopper">

This file has been truncated. show original

Would be great if somebody could have a look at it.

DanielMurphy22 · November 11, 2021, 9:33am

One of our developers at ISIS came across this problem too! The solution was to upload a .vtp file with the geometry cached which sped things up. They used this file in a test on these lines: https://github.com/mantidproject/mantid/blob/main/Framework/DataHandling/test/LoadEventNexusTest.h#L268-L275

Tell me if that works for you or if you need any help!